[ pulsar-ci-test] Fix checkstyle bookieRackAffinityMapping error - #13772
Merged
lhotari merged 2 commits intoJan 17, 2022
Merged
Conversation
liudezhi2098
changed the title
Contributor
Author
|
/pulsarbot run-failure-checks |
mattisonchao
approved these changes
Jan 16, 2022
6 tasks
yuruguo
approved these changes
Jan 16, 2022
3 tasks
Jason918
reviewed
Jan 17, 2022
|
|
||
| if (bi != null | ||
| && !Strings.isNullOrEmpty(bi.getRack()) | ||
| && !com.google.api.client.util.Strings.isNullOrEmpty(bi.getRack()) |
Contributor
There was a problem hiding this comment.
I think we can use "org.apache.commons.lang3.StringUtils#isEmpty" to avoid this checkstyle issue.
…commons.lang3.StringUtils#isEmpty
315157973
approved these changes
Jan 17, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
Jason918
approved these changes
Jan 17, 2022
hangc0276
approved these changes
Jan 17, 2022
nicoloboschi
approved these changes
Jan 17, 2022
eolivelli
approved these changes
Jan 17, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fix checkstyle bookieRackAffinityMapping error in pulsar-ci-test (group2)
Documentation
no-need-doc