[clean code] clean unused method: getRangeConsumer - #13775
Merged
codelipenghui merged 4 commits intoJan 26, 2022
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
Member
|
@lordcheng10 |
Jason918
approved these changes
Jan 17, 2022
Contributor
Author
|
ping |
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
hezhangjian
approved these changes
Jan 18, 2022
hezhangjian
left a comment
hezhangjian
left a comment
Member
There was a problem hiding this comment.
need to remove the import
codelipenghui
approved these changes
Jan 18, 2022
Contributor
|
@lordcheng10 Please rebase to the master branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
clean unused method: getRangeConsumer in class HashRangeAutoSplitStickyKeyConsumerSelector and ConsistentHashingStickyKeyConsumerSelector
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)