Skip to content

Allow to configure metadata store URL in proxy.conf - #13777

Merged
codelipenghui merged 2 commits into
apache:masterfrom
gaozhangmin:proxy-metaStoreUrl
Feb 7, 2022
Merged

Allow to configure metadata store URL in proxy.conf#13777
codelipenghui merged 2 commits into
apache:masterfrom
gaozhangmin:proxy-metaStoreUrl

Conversation

@gaozhangmin

@gaozhangmin gaozhangmin commented Jan 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Master Issue: #13077

Motivation

Allow to configure the metadata store endpoint in proxy.conf.

Modifications

Deprecated few config options:
zookeeperServers --> metadataStoreUrl
configurationStoreServers --> configurationMetadataStoreUrl
Moved all deprecated settings at the end of broker.conf.

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc
    site2/docs/administration-proxy.md
    site2/docs/concepts-architecture-overview.md
    site2/website-next/docs/administration-proxy.md
    site2/website-next/docs/concepts-architecture-overview.md

@github-actions

github-actions Bot commented Jan 17, 2022

Copy link
Copy Markdown

@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions

github-actions Bot commented Jan 17, 2022

Copy link
Copy Markdown

@gaozhangmin:Thanks for providing doc info!

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 17, 2022
@github-actions

github-actions Bot commented Jan 17, 2022

Copy link
Copy Markdown

@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions Bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs doc-label-missing labels Jan 17, 2022
@github-actions

github-actions Bot commented Jan 17, 2022

Copy link
Copy Markdown

@gaozhangmin:Thanks for providing doc info!

@github-actions github-actions Bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Jan 17, 2022
@gaozhangmin gaozhangmin mentioned this pull request Jan 17, 2022
Closed
@gaozhangmin
gaozhangmin force-pushed the proxy-metaStoreUrl branch 2 times, most recently from f8fcd24 to 9525615 Compare January 17, 2022 11:30
@Anonymitaet

Anonymitaet commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Hi @gaozhangmin thank you very much for your contribution!

However, from the doc side, we submitted a PR to fix this issue last week (#13758), you can see the references from the original PR (#13077)

image

And we also reported a code issue last week: #13760

@gaozhangmin So how about reverting doc changes in your PR? and

@momo-jun can you take a look at the doc changes in this PR and update your doc (if necessary)? Thanks

@gaozhangmin

gaozhangmin commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Anonymitaet I revert the docs change, But some docs about command line arguments are remained.

@gaozhangmin

gaozhangmin commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

codelipenghui
codelipenghui reviewed Jan 18, 2022
View reviewed changes
Comment thread conf/proxy.conf
@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 18, 2022
@nodece nodece mentioned this pull request Jan 20, 2022
Merged
1 task
@codelipenghui

codelipenghui commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

@RobertIndie Please help review this PR.

RobertIndie
RobertIndie requested changes Jan 26, 2022
View reviewed changes
Comment thread pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
Comment thread site2/docs/administration-proxy.md
Comment thread site2/docs/administration-proxy.md Outdated
Comment thread site2/docs/concepts-architecture-overview.md Outdated
Comment thread site2/website-next/docs/administration-proxy.md Outdated
Comment thread site2/website-next/docs/concepts-architecture-overview.md Outdated
Jason918
Jason918 reviewed Jan 26, 2022
View reviewed changes
Comment thread pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
Comment thread pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
Comment thread pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java Outdated
@gaozhangmin
gaozhangmin force-pushed the proxy-metaStoreUrl branch 2 times, most recently from 4b3257b to 55ceef1 Compare January 26, 2022 06:40
nicoloboschi
nicoloboschi requested changes Jan 26, 2022
View reviewed changes
Comment thread pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java Outdated
Comment thread pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
Comment thread pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java Outdated
Comment thread pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java Outdated
Comment thread pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
@codelipenghui

codelipenghui commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

@nicoloboschi Please help review this PR again, thanks.

@gaozhangmin

gaozhangmin commented Jan 28, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@gaozhangmin

gaozhangmin commented Jan 28, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui
codelipenghui merged commit 5552f57 into apache:master Feb 7, 2022
@liangyuanpeng liangyuanpeng mentioned this pull request Feb 20, 2022
Closed
@RobertIndie RobertIndie mentioned this pull request Apr 6, 2022
Closed
4 tasks
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@gaozhangmin nicklixinyang
Allow to configure metadata store URL in proxy.conf (apache#13777)
72f4868 
Master Issue: apache#13077

### Motivation

Allow to configure the metadata store endpoint in proxy.conf.

### Modifications

Deprecated few config options:
zookeeperServers --> metadataStoreUrl
configurationStoreServers --> configurationMetadataStoreUrl
Moved all deprecated settings at the end of broker.conf.
@ZiyaoWei ZiyaoWei mentioned this pull request Jun 10, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoloboschi nicoloboschi nicoloboschi requested changes
@hangc0276 hangc0276 hangc0276 approved these changes
@315157973 315157973 315157973 approved these changes
@codelipenghui codelipenghui codelipenghui approved these changes
@RobertIndie RobertIndie RobertIndie approved these changes
@aloyszhang aloyszhang Awaiting requested review from aloyszhang
@merlimat merlimat Awaiting requested review from merlimat
@Jason918 Jason918 Awaiting requested review from Jason918
@Technoboy- Technoboy- Awaiting requested review from Technoboy-

Assignees

@gaozhangmin gaozhangmin

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

9 participants

@gaozhangmin @Anonymitaet @codelipenghui @Jason918 @hangc0276 @Technoboy- @315157973 @RobertIndie @nicoloboschi