Add comment for using configurationMetadataStoreUrl instead of configurationStoreServers - #16012
Merged
Merged
Conversation
…figurationStoreServers`
|
@ZiyaoWei:Thanks for your contribution. For this PR, do we need to update docs? |
|
@ZiyaoWei:Thanks for providing doc info! |
github-actions
Bot
added
the
doc
merlimat
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#13777 deprecated
zookeeperServersandconfigurationStoreServers. However, while the former has comments pointing tometadataStoreUrlwhich should be used instead, the latter doesn't have comments about which field to use instead.Modifications
Add comments that point users to
configurationMetadataStoreUrl.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Need to update docs?
doc