Skip to content

Fix unit test testSharedInstance fail - #13908

Merged
codelipenghui merged 2 commits into
apache:masterfrom
shibd:fix-13907
Jan 24, 2022
Merged

Fix unit test testSharedInstance fail#13908
codelipenghui merged 2 commits into
apache:masterfrom
shibd:fix-13907

Conversation

@shibd

@shibd shibd commented Jan 23, 2022

Copy link
Copy Markdown
Member

Motivation

#13907

In this unit test, Two MetadataStore do not share a listener. when executed store2.delete, store1 existsCache is not invalidate.

@Test
public void testSharedInstance() throws Exception {
String url = "memory://" + UUID.randomUUID();
@Cleanup
MetadataStore store1 = MetadataStoreFactory.create(url,
MetadataStoreConfig.builder().build());
@Cleanup
MetadataStore store2 = MetadataStoreFactory.create(url,
MetadataStoreConfig.builder().build());

Modifications

  1. Let LocalMemoryMetadataStore instances with the same address register on the same listener

Documentation

  • no-need-doc

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 23, 2022
@shibd

shibd commented Jan 23, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

2 similar comments
@shibd

shibd commented Jan 23, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@shibd

shibd commented Jan 23, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@shibd

shibd commented Jan 24, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

1 similar comment
@shibd

shibd commented Jan 24, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@codelipenghui
codelipenghui merged commit b208ab0 into apache:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants