Remove Persistent Topics v3 API - use custom media type instead - #14117
Merged
Conversation
lhotari
requested review from
Technoboy-,
codelipenghui,
eolivelli,
merlimat and
michaeljmarshall
February 4, 2022 10:24
BewareMyPower
approved these changes
Feb 4, 2022
eolivelli
approved these changes
Feb 4, 2022
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
LGTM
but we should find a way to clearly document this in the documentation
maybe swagger is already well documenting this new media type?
could you please verify ?
merlimat
approved these changes
Feb 4, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…he#14117) * Remove Persistent Topics v3 API - use custom media type instead * Don't pass properties if there are none * Cleanup remains of topicV3, use old API method when no properties are set * Fix tests
Member
@eolivelli Swagger distinguishes endpoints by verb + path only. It can be a docs issue, see also #18947. |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14104
Motivation
The challenge seems to be that in the old method, the number of partitions was passed in the payload as a single integer without having a JSON object at all. This makes it harder to extend the existing API, but doesn’t make it impossible.
Content-Type: application/vnd.partitioned-topic-metadata+jsonon request,@Consumes("application/vnd.partitioned-topic-metadata+json")on method that handles the new payload type.Modifications
application/vnd.partitioned-topic-metadata+jsonto distinguish the new content payload type