[fix][client] ExtNonPersistentTopics and prevent prefix match - #19065
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
fix-prefix-match
branch
from
December 26, 2022 14:56
0f28be0 to
3794711
Compare
Member
Author
|
Verified with |
tisonkun
commented
Dec 26, 2022
| try { | ||
| validateNamespaceName(tenant, namespace); | ||
| validateGlobalNamespaceOwnership(); | ||
| validateTopicName(tenant, namespace, encodedTopic); |
Member
Author
Codecov Report
@@ Coverage Diff @@
## master #19065 +/- ##
============================================
+ Coverage 47.11% 47.37% +0.26%
- Complexity 10595 10711 +116
============================================
Files 710 711 +1
Lines 69423 69454 +31
Branches 7449 7452 +3
============================================
+ Hits 32709 32907 +198
+ Misses 33037 32877 -160
+ Partials 3677 3670 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BewareMyPower
approved these changes
Dec 26, 2022
yuruguo
reviewed
Dec 26, 2022
…ExtNonPersistentTopics.java
tuteng
approved these changes
Dec 27, 2022
Member
Author
|
Merging... |
tisonkun
added a commit
to tisonkun/pulsar
that referenced
this pull request
Dec 27, 2022
…#19065) Signed-off-by: tison <wander4096@gmail.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is a follow-up to #19025. That the swagger plugin is matching by prefix so we have to distinguish the class name in prefix.
Also add back the inherit logic for
NonPersistentTopicsand fix a bug inline.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: