Removed usage of sample/standalone/ns1 namespaces in standalone - #15186
Merged
Conversation
merlimat
added
type/cleanup
merlimat
requested review from
BewareMyPower,
codelipenghui,
eolivelli and
hangc0276
April 15, 2022 17:53
Demogorgon314
approved these changes
Apr 16, 2022
hezhangjian
approved these changes
Apr 16, 2022
Jason918
approved these changes
Apr 16, 2022
mattisonchao
approved these changes
Apr 16, 2022
HQebupt
approved these changes
Apr 16, 2022
liudezhi2098
approved these changes
Apr 18, 2022
hangc0276
approved these changes
Apr 18, 2022
RobertIndie
approved these changes
Apr 18, 2022
liangyuanpeng
approved these changes
Apr 18, 2022
Technoboy-
approved these changes
May 3, 2022
2 tasks
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Dec 13, 2022
### Motivation apache#15186 changed the behavior of how to create the default namespace. However, it brings a regression that even if the built-in admin didn't have the authentication configured while the standalone enabled the authentication, the namespace could still be created successfully. This PR also changed the deploy script to remove the creation of "public/default" namespace. Instead, it grants the permission to this namespace directly. After apache#17864 and apache#18837, the namespace will be created by the built-in admin again. But the deploy script would fail. ### Modifications Create the default namespace via `pulsar-admin` in the deploy script.
This was referenced Dec 13, 2022
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Dec 13, 2022
### Motivation Fix the regression brought by apache#15186. See https://lists.apache.org/thread/vz3tqpgs5l1r0trq29r4hdf85t0rjc8j for details. ### Modifications Use `PulsarAdmin` to initialize the metadata so that it would fail if the authentication of the built-in clients were not configured correctly. Add a `testMetadataInitialization` to avoid the regression. And move the bundle policy test from `SmokeTest` to this test.
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Dec 13, 2022
…zation ### Motivation Fix the regression brought by apache#15186. See https://lists.apache.org/thread/vz3tqpgs5l1r0trq29r4hdf85t0rjc8j for details. ### Modifications Use `PulsarAdmin` to initialize the metadata so that it would fail if the authentication of the built-in clients were not configured correctly. Add a `testMetadataInitialization` to avoid the regression. And move the bundle policy test from `SmokeTest` to this test. xxx
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
sample/standalone/ns1namespace was introduced Pulsar 1.x for documentation examples when running standalone service.It was superseded in Pulsar 2.x by
public/defaultnamespace and it's really not needed anymore to be created.