[fix][broker] Create "standalone" cluster when starting standalone server - #15583
Merged
Conversation
merlimat
approved these changes
May 13, 2022
Contributor
|
@massakam The CPP tests are failing because the script is creating the |
codelipenghui
approved these changes
May 14, 2022
Contributor
|
/pulsarbot run-failure-checks |
Jason918
approved these changes
May 14, 2022
Contributor
Author
Fixed the script to create the standalone cluster only if it doesn't exist. |
Technoboy-
approved these changes
May 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Up to version 2.10.0, we could create any tenant as soon as we started the standalone server. However, the current master cannot do that.
Modifications
The reason why tenant creation fails is that the "standalone" cluster does not actually exist.
$ grep 'clusterName' conf/standalone.conf clusterName=standalone $ ./bin/pulsar-admin clusters get standalone Cluster does not exist Reason: Cluster does not existThe process of creating this cluster has been removed in #15186, but it seems that there is no need to remove it. So, I added the process of creating the "standalone" cluster again.
Verifying this change
Documentation
no-need-doc