[cleanup][broker] Remove duplicate code to improve delete subscription - #15347
Merged
Conversation
nodece
force-pushed
the
improve_delete_subscription
branch
2 times, most recently
from
April 27, 2022 15:09
33c34ea to
b8f8a2b
Compare
1 task
nodece
force-pushed
the
improve_delete_subscription
branch
from
April 28, 2022 04:35
b8f8a2b to
0c64c79
Compare
Member
Author
|
/pulsarbot rerun-failure-checks |
leizhiyuan
approved these changes
Apr 28, 2022
leizhiyuan
left a comment
leizhiyuan
left a comment
Contributor
There was a problem hiding this comment.
LGMT, I cherryed pick the code for my test , It is ok now
leizhiyuan
reviewed
Apr 28, 2022
HQebupt
approved these changes
Apr 30, 2022
shibd
approved these changes
Apr 30, 2022
|
The pr had no activity for 30 days, mark with Stale label. |
Member
|
@nodece we can proceed this patch if you can rebase and resolve the conflict. What do you think? |
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nodece
force-pushed
the
improve_delete_subscription
branch
from
December 16, 2022 09:11
dc132e5 to
e3def84
Compare
Member
Author
Done. |
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
apache#15347) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
1 task
michaeljmarshall
added a commit
that referenced
this pull request
Jan 11, 2023
### Motivation In #15347, there is a regression where the `subName` needed to be passed to the authorization provider. That PR is not released, so this PR is just cleanup ### Modifications * Pass `subName` for `validateTopicOperationAsync` in `PersistentTopicsBase#internalDeleteSubscriptionForNonPartitionedTopicAsync` ### Verifying this change We should add testing to this part of the code base to prevent future regressions. Issue requesting better testing is added: #19183. ### Does this pull request potentially affect one of the following parts: This is not a breaking change. ### Documentation - [x] `doc-not-needed`
This was referenced Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15324
Motivation
internalDeleteSubscriptionForcefullyandinternalDeleteSubscriptionhave duplicate code, and we should also avoid using synchronization methods likegetTopicReference().Modifications
internalDeleteSubscription()Documentation
no-need-docJust cleanup