[fix][broker] Fix MultiRolesTokenAuthorizationProvider authorize issue. - #15454
Merged
Conversation
nodece
reviewed
May 7, 2022
RobertIndie
reviewed
May 7, 2022
RobertIndie
left a comment
Member
There was a problem hiding this comment.
Please follow the PR title convention.
authorize issue.
codelipenghui
approved these changes
May 8, 2022
RobertIndie
approved these changes
May 8, 2022
mattisonchao
approved these changes
May 9, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 23, 2022
…sue. (apache#15454) (cherry picked from commit 19f61d5) (cherry picked from commit 836ed1e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Method
authorizeusing the common pool thread and has a sync call :pulsar/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/MultiRolesTokenAuthorizationProvider.java
Lines 137 to 161 in afc48e6
And if line-141 has an exception, the future could not complete.
Documentation
no-need-doc(Please explain why)