[improve][common] Use Collection instead of List for FutureUtil. - #15329
Merged
Conversation
Technoboy-
changed the title
Collection instead of List parameter type.Collection instead of List for FutureUtil.
Member
Author
|
/pulsarbot rerun-failure-checks |
BewareMyPower
approved these changes
Apr 26, 2022
Technoboy-
approved these changes
Apr 26, 2022
Technoboy-
requested review from
codelipenghui,
congbobo184,
eolivelli,
hangc0276 and
lhotari
April 26, 2022 12:11
liangyepianzhou
approved these changes
Apr 26, 2022
nodece
approved these changes
Apr 26, 2022
shibd
approved these changes
Apr 26, 2022
RobertIndie
approved these changes
Apr 26, 2022
RobertIndie
added
the
type/enhancement
codelipenghui
pushed a commit
that referenced
this pull request
May 20, 2022
#15329) ### Motivation We can use `Collection` instead of `List` parameter type in `FutureUtil` for better compatibility. For example when we need to use the values of `Map`: ```java FutureUtil.waitForAll(map.values()); ``` ### Modifications - Use `Collection` instead of `List` parameter type. (cherry picked from commit 0c694cf)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 23, 2022
apache#15329) ### Motivation We can use `Collection` instead of `List` parameter type in `FutureUtil` for better compatibility. For example when we need to use the values of `Map`: ```java FutureUtil.waitForAll(map.values()); ``` ### Modifications - Use `Collection` instead of `List` parameter type. (cherry picked from commit 0c694cf) (cherry picked from commit 08219ae)
nicoloboschi
added a commit
to datastax/pulsar
that referenced
this pull request
May 26, 2022
…eter type (apache#15329)" This reverts commit c04bebc.
1 task
mattisonchao
added
release/2.9.4
cherry-picked/branch-2.9
mattisonchao
added a commit
that referenced
this pull request
Jul 2, 2022
#15329) ### Motivation We can use `Collection` instead of `List` parameter type in `FutureUtil` for better compatibility. For example when we need to use the values of `Map`: ```java FutureUtil.waitForAll(map.values()); ``` ### Modifications - Use `Collection` instead of `List` parameter type. (cherry picked from commit 0c694cf)
mattisonchao
removed
cherry-picked/branch-2.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We can use
Collectioninstead ofListparameter type inFutureUtilfor better compatibility.For example when we need to use the values of
Map:Modifications
Collectioninstead ofListparameter type.Verifying this change
Documentation
no-need-docdoc-not-needed