[refactor][client] Reusing multi-topics reader to implement TableView auto-update partition - #15589
Merged
codelipenghui merged 2 commits intoMay 17, 2022
Merged
Conversation
Technoboy-
added
type/enhancement
Demogorgon314
marked this pull request as ready for review
May 13, 2022 12:54
Technoboy-
approved these changes
May 13, 2022
merlimat
reviewed
May 13, 2022
codelipenghui
approved these changes
May 14, 2022
Contributor
|
/LGTM |
Contributor
|
@merlimat Please help review this PR again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the TableViewImpl itself maintains the reader per partition to support auto-update partition, but the reader support muti-partition topic and auto-update partitions, we should reuse the
MultiTopicsReaderImplto implement the TableView.Modifications
Reusing
MultiTopicsReaderImplto implement TableView auto-update partition.Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)