[fix][tableview] Fixed ack failure in ReaderImpl due to null messageId - #17828
Merged
Jason918 merged 1 commit intoSep 25, 2022
Merged
Conversation
|
@heesung-sn Please provide a correct documentation label for your PR. |
12 tasks
heesung-sohn
force-pushed
the
branch-2.10-fix-reader-ack
branch
from
September 24, 2022 00:29
e7b5fdd to
44aedee
Compare
Jason918
changed the title
Jason918
reviewed
Sep 24, 2022
| assertEquals(tv.get("key2"), "value2"); | ||
| } | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
I see an internal data structure change for the reader member in TableView. The testAck in the master branch will fail in 2.10 branch.
2.10
private final ConcurrentMap<String, Reader<T>> readers;
master
private final CompletableFuture<Reader<T>> reader;
We could add the test when merging this update in branch-2.10.
Contributor
There was a problem hiding this comment.
We could add the test when merging this update in branch-2.10.
I see, it's introduced in #15589, which is a refactor and not necessary for patch releases.
Contributor
|
/pulsarbot run-failure-checks |
Jason918
added
release/2.10.2
doc-not-needed
github-actions
Bot
added
doc-label-missing
and removed
doc-not-needed
Jason918
approved these changes
Sep 25, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 28, 2022
apache#17728) (apache#17828) (cherry picked from commit bbccb62)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick from the master requested by #17728 (comment)