[PIP][broker]PIP-162: Enable system topic by default. - #15619
Merged
Conversation
Technoboy-
added
doc
codelipenghui
approved these changes
May 16, 2022
codelipenghui
added
release/important-notice
HQebupt
approved these changes
May 17, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
Technoboy-
force-pushed
the
enable-system-topic
branch
from
May 19, 2022 01:11
969d173 to
96f4117
Compare
Technoboy-
changed the title
Technoboy-
force-pushed
the
enable-system-topic
branch
from
May 21, 2022 09:50
887ad60 to
c3e7b66
Compare
Technoboy-
changed the title
gaoran10
reviewed
May 23, 2022
gaoran10
left a comment
gaoran10
left a comment
Contributor
There was a problem hiding this comment.
Great work! I found some tests must disable the system topic and topic level policies, I'm not sure if there are break changes or if the test requires disabling topic level policies.
Contributor
Author
Because the old behavior is disable the system topic. so we need to disable it explicitly so that some test could pass. Otherwise like metrics maybe affect by the system topic. |
mattisonchao
approved these changes
May 23, 2022
congbobo184
approved these changes
May 23, 2022
1 task
14 tasks
Merged
4 tasks
AlvaroStream
added a commit
to AlvaroStream/pulsar-site
that referenced
this pull request
Jun 28, 2023
Not valid from 2.6.0 Thanks @gaoran10 > We introduce topic-level policies from 2.6.0, refer to apache/pulsar#4955, but I think we support retention policies at the topic level from 2.7.0, refer to apache/pulsar#7747. >Make the default value of the configuration topicLevelPoliciesEnabled as true from 2.11.0, refer to apache/pulsar#15619.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15333
Motivation
In PIP-39, we have introduced namespace event to support topic level policy. This feature was released in Pulsar 2.6.
Then PIP-92, we support topic policy to replicate across clusters and release in Pulsar 2.10.
And with version iteration, the corresponding topic policy CLI and functions are mature and stable, but users need to enable system topic to support these features. So it's better to enable system topic by default.
Documentation
doc(Your PR contains doc changes)