[fix][broker] Filter system topic when getting topic list by binary proto.

[shibd]

Motivation

In v2.11.0, the system topic enables by default. This causes the GET_TOPICS_OF_NAMESPACE command to return the system topic redundantly.

And, If the transaction is enabled, the transaction-related system topic will return by the client(__transaction_buffer_snapshot, __transaction_buffer_snapshot_segments, __transaction_buffer_snapshot_indexes). This PR filters some transaction-related topics, but these are missing.

This causes some incompatibility issues: If consumers use pattern subscribe and the pattern is /tenant/namespace/.*, it will subscribe to these system topics.

Discuss mail: https://lists.apache.org/thread/qhm0zbfw0wfd1m5vj977w002qmkr5lt9

Modifications

• Filter system topic when getting topic list by binary proto.

Verifying this change

• testBinaryProtoSubscribeAllTopicOfNamespace will cover the don't subscribe system topic.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: shibd#21

[poorbarcode]

Hi @shibd
These system topics are defined by PIP-178. Could we only filter out these topics instead of all system topics?

Hi @liangyepianzhou
Could you review this PR?

[shibd]

These system topics are defined by #16042. Could we only filter out these topics instead of all system topics?

Why? I think we should filter all system topics, these topics should be invisible to the user.

[eolivelli]

+1

we should cherry pick this to branch-2.11