[fix][test] Fix CoordinatorService, MetadataStore and MockZooKeeper leaks in tests #15638
Merged
lhotari merged 10 commits intoJul 13, 2022
Merged
Conversation
nicoloboschi
force-pushed
the
fix-tests-close-managed-ledger
branch
from
May 17, 2022 13:04
e16c266 to
bd66618
Compare
1 task
Contributor
|
Will reopen later to re-run the test. |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
nicoloboschi
force-pushed
the
fix-tests-close-managed-ledger
branch
from
May 19, 2022 08:25
280557d to
86b7d07
Compare
Contributor
Author
|
Test failed is not related, I opened an issue: #15676 |
nicoloboschi
requested review from
Jason918,
eolivelli,
lhotari and
merlimat
and removed request for
Jason918 and
eolivelli
May 20, 2022 08:22
lhotari
requested review from
Technoboy-,
eolivelli,
mattisonchao and
michaeljmarshall
May 20, 2022 11:34
Contributor
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot rerun-failure-checks |
dlg99
approved these changes
May 20, 2022
Member
|
@nicoloboschi Please rebase this PR. It looks like this could help with these issues which happen in PulsarFunctionTlsTest.tearDown: This is the 4th most flaky issue currently. |
nicoloboschi
force-pushed
the
fix-tests-close-managed-ledger
branch
2 times, most recently
from
June 6, 2022 11:48
8006c99 to
cf21267
Compare
|
The pr had no activity for 30 days, mark with Stale label. |
4 tasks
nicoloboschi
force-pushed
the
fix-tests-close-managed-ledger
branch
from
July 12, 2022 08:02
d63a9b2 to
5cd2170
Compare
lhotari
requested changes
Jul 12, 2022
Contributor
Author
|
@lhotari PTAL |
merlimat
approved these changes
Jul 12, 2022
lhotari
reviewed
Jul 13, 2022
lhotari
approved these changes
Jul 13, 2022
Closed
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
…eaks in tests (apache#15638) * [fix][tests] Ensure thread pools are disposed after some tests * fix comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There are some tests that occasionally fails with non-sense mockito errors like this one:
After investigating I noticed that MetadataStore threads can still receive notifications even if the current test method is finished. Also other thread pools are not shutdown in the correct way and the test must wait for their terminations in order to avoid mixing up Mockito mocked objects.
Modifications
MockedBookKeeperTestCasebased testsThis is related to past flaky-tests like:
fix #15774
no-need-doc