Skip to content

[fix][test] Disable ReuseFork for broker group 1 - #16461

Merged
merlimat merged 1 commit into
apache:masterfrom
codelipenghui:penghui/disable_ReuseFork
Jul 9, 2022
Merged

[fix][test] Disable ReuseFork for broker group 1#16461
merlimat merged 1 commit into
apache:masterfrom
codelipenghui:penghui/disable_ReuseFork

Conversation

@codelipenghui

@codelipenghui codelipenghui commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

Fixes: #16382

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jul 8, 2022
@codelipenghui codelipenghui self-assigned this Jul 8, 2022
@codelipenghui codelipenghui added this to the 2.11.0 milestone Jul 8, 2022
@codelipenghui
codelipenghui marked this pull request as ready for review July 8, 2022 02:32
@dave2wave

Copy link
Copy Markdown
Member

/pulsarbot rerun-failure-checks

@merlimat
merlimat merged commit 5bad9b3 into apache:master Jul 9, 2022
@mattisonchao

mattisonchao commented Jul 9, 2022

Copy link
Copy Markdown
Member

Question:
Why ReuseFork can cause this problem?

@codelipenghui
codelipenghui deleted the penghui/disable_ReuseFork branch July 9, 2022 01:28
zymap pushed a commit to zymap/pulsar that referenced this pull request Jul 11, 2022
@nicoloboschi

Copy link
Copy Markdown
Contributor

I don't think this is a correct fix. the problem in #16382 should be fixed with something like #15638. I'll try to finish the work in these days

@nicoloboschi

Copy link
Copy Markdown
Contributor

just realized you re-enabled it in 56f96da

wuxuanqicn pushed a commit to wuxuanqicn/pulsar that referenced this pull request Jul 14, 2022
@mattisonchao

Copy link
Copy Markdown
Member

I think we don't need to cherry-pick this PR to branch 2.9, could you help to confirm it? @codelipenghui

nodece pushed a commit to ascentstream/pulsar that referenced this pull request Mar 19, 2025
(cherry picked from commit 5bad9b3)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky-test: PersistentTopicTest.setup

5 participants