[branch-2.10][fix][common] Add back FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter - #15810
Merged
Conversation
Contributor
Author
|
@mattisonchao @eolivelli PTAL |
Contributor
|
@BewareMyPower this patch fixes KoP on 2.10.1 |
mattisonchao
approved these changes
May 26, 2022
mattisonchao
left a comment
mattisonchao
left a comment
Member
There was a problem hiding this comment.
It's better to add deprecated annotation or just revert #15329 at branch-2.10?
Contributor
Author
|
The deprecated annotation makes sense. There's a cherry-pick issue on branch-2.10 (not related to this pull) that makes the CI fails, will fix it |
Contributor
|
I agree. We should not introduce the API changes in patch releases. |
BewareMyPower
approved these changes
May 27, 2022
nodece
approved these changes
May 27, 2022
…y methods with List parameter
nicoloboschi
force-pushed
the
readd-futureutil
branch
from
May 27, 2022 10:19
5658a8d to
beb7def
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #15329 FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter have been removed.
If an application uses one of that method, it won't be able to switch from 2.10.0 to 2.10.1 (it will get a NoSuchMethodError exception).
Even if those methods are intedend to internal use only, this kind of breaking changes are not justified in a patch release.
For example both Stream Native KoP and Datastax Starlight for Kafka use the
waitForAllmethod.Modifications
Re add the List specific version of those methods
doc-not-needed