[build][sql] Make pulsar-trino-disto self-contained - #17062
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
0c10d97 to
66cc857
Compare
Signed-off-by: tison <wander4096@gmail.com>
66cc857 to
a3454a6
Compare
Signed-off-by: tison <wander4096@gmail.com>
|
Seems good. Let me handle all the remaining renaming things and try to prepare a PIP. |
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
I overall agree with the patch.
I have left some comments about the PR style
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
500af93 to
43c8c7d
Compare
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
codelipenghui
left a comment
codelipenghui
left a comment
There was a problem hiding this comment.
Nice work.
LGTM, I have tried on my laptop. Pulsar SQL works great.
|
Thanks for your reviews! I think this patch is ready for merge. @eolivelli @codelipenghui @nicoloboschi could you help with performing the merge? After it's merged I'll update the corresponding docs and then we can close PIP-200 as completed. |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
It seems broker group 2 tests don't like me, lol. Update branch and rerun. |
|
Now broker group 1 tests don't like me :( Rerun later >_< |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
@nicoloboschi I think the unrequired check status is due to your action. Do you think it's good to merge this PR now? |
|
Finally! @codelipenghui @nicoloboschi could you help with merging this XD |
7 participants
Master issue #17137
doc-not-needed