[chore][test] Check LineLength only for Java files - #17168
Merged
Conversation
1 task
codelipenghui
approved these changes
Aug 19, 2022
RobertIndie
approved these changes
Aug 19, 2022
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
cc @eolivelli @codelipenghui @RobertIndie I hope this patch is ready for merge now. |
Member
Author
|
/pulsarbot run-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I prototyping #17062 I met the issue that a text file can contain properties very long and that's proper.
Instead of suppressing them file by file, I think the original purpose we turn on LineLength is for checking Java files. So I propose this change.
doc-not-neededcc @eolivelli @lhotari @shoothzj @RobertIndie