[cleanup][broker]remove unnecessary variable#17768
Merged
lhotari merged 3 commits intoSep 22, 2022
Merged
Conversation
lordcheng10
force-pushed
the
clean_code_remove_unused_policiesCache
branch
from
September 21, 2022 14:09
719cb57 to
07154b7
Compare
Technoboy-
approved these changes
Sep 22, 2022
Jason918
approved these changes
Sep 22, 2022
Member
|
Just wondering if you could run the unused variable inspection for the whole code base and make a single PR to fix that? It's possible to use Errorprone for scanning unused variables & fields. There's |
4 tasks
lordcheng10
changed the title
aloyszhang
approved these changes
Sep 22, 2022
Contributor
Author
OK, I create a new PR to check all unused variables for the whole code. |
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Apr 11, 2024
… creating OwnershipCache ### Motivation apache#11012 removes all uses of the `NamespaceBundleFactory` field in `OwnershipCache` and apache#17768 removes that field. However, the constructor of `OwnershipCache` still has the `NamespaceBundleFactory` parameter. ### Modifications Remove that parameter from the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Variable policiesCache in NamespaceBundleFactory is not used.
Variable bundleFactory_ in OwnershipCache is not used.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository:
lordcheng10#12