Skip to content

[cleanup][broker]remove unnecessary variable in OwnershipCache - #17788

Closed
lordcheng10 wants to merge 1 commit into
apache:masterfrom
lordcheng10:clean_bundleFactory_OwnershipCache
Closed

[cleanup][broker]remove unnecessary variable in OwnershipCache#17788
lordcheng10 wants to merge 1 commit into
apache:masterfrom
lordcheng10:clean_bundleFactory_OwnershipCache

Conversation

@lordcheng10

@lordcheng10 lordcheng10 commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Motivation

Variable bundleFactory_ in OwnershipCache is not used.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: lordcheng10#16

After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.

apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.

The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.

-->

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please combine this to #17768 , it doesn't make sense to submit these one-by-one.

@lordcheng10

Copy link
Copy Markdown
Contributor Author

Please combine this to #17768 , it doesn't make sense to submit these one-by-one.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants