[fix][cli] Check numMessages after incrementing counter - #17826
Merged
Conversation
andrasbeni
changed the title
codelipenghui
approved these changes
Sep 28, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
congbobo184
pushed a commit
that referenced
this pull request
Nov 14, 2022
(cherry picked from commit df5e0e1)
congbobo184
pushed a commit
that referenced
this pull request
Dec 7, 2022
(cherry picked from commit df5e0e1)
14 tasks
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17823
Motivation
If PerformanceReader can read exactly as many messages as specified by
num-messages, it does not stop but waits for another message.Modifications
Check the number of total messages after incrementing the counter.
Verifying this change
This change added tests and can be verified as follows:
pulsar-perf readDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededThis is a bugfix
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: andrasbeni#6