[cherry-pick][branch-2.10] Check numMessages after incrementing counter and NPE cause - #18885
Merged
liangyepianzhou merged 2 commits intoDec 13, 2022
Merged
[cherry-pick][branch-2.10] Check numMessages after incrementing counter and NPE cause#18885liangyepianzhou merged 2 commits into
liangyepianzhou merged 2 commits into
Conversation
liangyepianzhou
requested review from
hangc0276,
liudezhi2098 and
yuruguo
and removed request for
liudezhi2098 and
yuruguo
December 12, 2022 09:10
liangyepianzhou
changed the title
congbobo184
approved these changes
Dec 13, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
…er and NPE cause (apache#18885) Co-authored-by: Lei Zhiyuan <leizhiyuan@gmail.com> (cherry picked from commit ca001b3)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
…er and NPE cause (apache#18885) Co-authored-by: Lei Zhiyuan <leizhiyuan@gmail.com> (cherry picked from commit ca001b3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry-pick #17826 and #17705 for releasing 2.10.3 and run the tests.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: