[improve][test] Improve SimpleProducerConsumerTest to reduce the execution time - #17887
Conversation
poorbarcode
left a comment
poorbarcode
left a comment
There was a problem hiding this comment.
I think this conf should be reset after method
|
|
||
| for (String tenant : admin.tenants().getTenants()) { | ||
| for (String namespace : admin.namespaces().getNamespaces(tenant)) { | ||
| admin.namespaces().deleteNamespace(namespace, true); |
There was a problem hiding this comment.
Suggest to use deleteNamespaceGraceFully, because delete namespace is not a stable cmd, see #17157.
Note that deleteNamespaceGraceFully runs slower than delete namespace and is unsuitable for all scenarios.
There was a problem hiding this comment.
Suggest to use
deleteNamespaceGraceFully, becausedelete namespaceis not a stable cmd, see #17157.Note that
deleteNamespaceGraceFullyruns slower thandelete namespaceand is unsuitable for all scenarios.
in my CI test, There are two failures related to these changes:
Time elapsed failures while excute deleteNamespaceGraceFully
see the checks in https://github.com/apache/pulsar/actions/runs/3242148385/jobs/5326408439
could i skip this test temporary？
There was a problem hiding this comment.
@poorbarcode hi
my CI check always fails in Pulsar CI Flaky / Flaky tests suite . seem releted to run deleteNamespaceGraceFully
cloud you please help me confirm the reason? thx
https://github.com/apache/pulsar/actions/runs/3242148385/jobs/5359655987
There was a problem hiding this comment.
@ethqunzhong I see, could you rebase master and see if it reproduces?
There was a problem hiding this comment.
Hi @ethqunzhong If you said PR #17803, then the error does not affect the merge
afd2949 to
6a550af
Compare
|
@codelipenghui PTAL. |
|
@coderzc @codelipenghui there were failures in the CI for this pull in the flaky test suite. See the checks https://github.com/apache/pulsar/actions/runs/3219150517 There are two failures related to these changes:
Could you please address them? |
5 participants
Fixed
Modifications
Only execution once
setup/cleanand cleantenants/namespaces/producer/consumerafter the end of each test execution.Execution time after improve test:
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: coderzc#7