[improve][broker] make managedLedgerOffloadedReadPriority compatible with broker property - #17803
Merged
codelipenghui merged 20 commits intoNov 1, 2022
Conversation
…hreshold-support-negative Set namespace offload policy threshold support negative
ethqunzhong
commented
Sep 27, 2022
HQebupt
approved these changes
Sep 28, 2022
Contributor
Author
|
i have add Matching PR in forked repository ethqunzhong#2 |
HQebupt
approved these changes
Oct 13, 2022
Contributor
Author
|
CI ALL passed: ethqunzhong#2 |
ethqunzhong
changed the title
Contributor
Author
|
/pulsarbot rerun-failure-checks |
eolivelli
approved these changes
Oct 13, 2022
Contributor
|
maybe you can rebase onto latest master |
ethqunzhong
force-pushed
the
bugfix-compatible-with-managedLedgerDataReadPriority
branch
from
October 13, 2022 11:56
fc8be9e to
9d3a053
Compare
Contributor
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot rerun-failure-checks |
4 tasks
ethqunzhong
force-pushed
the
bugfix-compatible-with-managedLedgerDataReadPriority
branch
from
October 17, 2022 09:29
9d3a053 to
e5b3e24
Compare
Contributor
Author
|
/pulsarbot rerun-failure-checks |
3 similar comments
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
ethqunzhong
force-pushed
the
bugfix-compatible-with-managedLedgerDataReadPriority
branch
from
October 18, 2022 09:27
e5b3e24 to
a6a69fd
Compare
Contributor
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot rerun-failure-checks |
hangc0276
approved these changes
Oct 19, 2022
ethqunzhong
force-pushed
the
bugfix-compatible-with-managedLedgerDataReadPriority
branch
from
October 20, 2022 03:39
a6a69fd to
14861ed
Compare
Contributor
Author
|
/pulsarbot rerun-failure-checks |
codelipenghui
added
type/enhancement
4 tasks
momo-jun
added
doc-complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As #16436 supported setManagedLedgerOffloadedReadPriority by broker.conf.
I add an unit-test to verify offloadpolicy-brokerconf-compatibled that test failed, show as follow:
offloadedDataReadPriority excepted value is
bookkeper-firstfrom broker's property but get default valuetiered-storage-first.Modifications
Fix
OffloadPoliciesImpl#getCompatibleValuelogic: add broker's propertymanagedLedgerDataReadPrioritycompatible.Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: ethqunzhong#2