[fix][ci] succeed only if all needs pass - #17923
Closed
tisonkun wants to merge 1 commit into
Closed
Conversation
This OR logic has been introduced by apache#17614. I don't know why it's added in the first place - we shouldn't have a OR here. But anyway since pulsar-client-cpp moved out, it should be reasonable to fix the workflow.
Member
Author
Member
The point of it was that when cpp build still existed, and there was a cpp only change, the unit & integration tests would have been skipped. the logic was for that purpose. The problem was that it wasn't properly removed in #17881 . |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This OR logic has been introduced by #17614.
I don't know why it's added in the first place - we shouldn't have an OR here. But anyway since pulsar-client-cpp moved out, it should be reasonable to fix the workflow.
Otherwise, if system tests passed but other tests failed or canceled, the required status can still pass.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: tisonkun#5