Skip to content

[fix][ci] CI: fix required jobs check - #17926

Merged
lhotari merged 1 commit into
apache:masterfrom
nicoloboschi:fix-ci-approvals
Oct 4, 2022
Merged

[fix][ci] CI: fix required jobs check#17926
lhotari merged 1 commit into
apache:masterfrom
nicoloboschi:fix-ci-approvals

Conversation

@nicoloboschi

@nicoloboschi nicoloboschi commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Motivation

After #17881 the "CI checks completed" job only verify the system-tests, bypassing all the other tests. Diff https://github.com/apache/pulsar/pull/17881/files#diff-069360707fedfc682947effc8f7fac874fa378ec5c70abec25f88939c87379d3R959

I noticed it in #17915
Screen Shot 2022-10-04 at 1 49 31 PM

Modifications

  • Restore all the required jobs verification

Also closes #17923

  • doc-not-needed

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Oct 4, 2022
@nicoloboschi
nicoloboschi requested review from lhotari and merlimat and removed request for lhotari October 4, 2022 11:50
@nicoloboschi

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @nicoloboschi !

@lhotari

lhotari commented Oct 4, 2022

Copy link
Copy Markdown
Member

It looks that @tisonkun made a similar change in #17923 . I guess we could keep on going with this one since the builds are already started? Perhaps @tisonkun could be added a co-author for this one while merging?

@tisonkun

tisonkun commented Oct 4, 2022

Copy link
Copy Markdown
Member

@lhotari looks good to me. Please edit the PR description to close #17923 so that we can link PRs. I just keep #17923 as is since the condition to close it is this PR merged.

@lhotari

lhotari commented Oct 4, 2022

Copy link
Copy Markdown
Member

https://github.com/apache/pulsar/actions/runs/3181864030/jobs/5189239809#step:12:28097

  stdout: Incorrect proxyProtocol name
  
  stderr: java.lang.IllegalArgumentException: No enum constant org.apache.pulsar.client.api.ProxyProtocol.
  	at java.base/java.lang.Enum.valueOf(Enum.java:273)
  	at org.apache.pulsar.client.api.ProxyProtocol.valueOf(ProxyProtocol.java:28)
  	at org.apache.pulsar.testclient.PerformanceBaseArguments.fillArgumentsFromProperties(PerformanceBaseArguments.java:153)
  	at org.apache.pulsar.testclient.PerformanceConsumer.main(PerformanceConsumer.java:264)

I wonder this is related to #17862

@lhotari

lhotari commented Oct 4, 2022

Copy link
Copy Markdown
Member

I'm working on a fix for the " stdout: Incorrect proxyProtocol name , stderr: java.lang.IllegalArgumentException: No enum constant org.apache.pulsar.client.api.ProxyProtocol." issue.

@lhotari

lhotari commented Oct 4, 2022

Copy link
Copy Markdown
Member

I'm working on a fix for the " stdout: Incorrect proxyProtocol name , stderr: java.lang.IllegalArgumentException: No enum constant org.apache.pulsar.client.api.ProxyProtocol." issue.

#17930 fixes this issue. @nicoloboschi @tisonkun please review

@lhotari
lhotari requested a review from BewareMyPower October 4, 2022 15:49
@nicoloboschi

Copy link
Copy Markdown
Contributor Author

@lhotari looks good to me. Please edit the PR description to close #17923 so that we can link PRs. I just keep #17923 as is since the condition to close it is this PR merged.

I'm sorry @tisonkun . I updated the description to close your pull

@lhotari

lhotari commented Oct 4, 2022

Copy link
Copy Markdown
Member

picking up #17930 changes by closing and re-opening

@lhotari lhotari closed this Oct 4, 2022
@lhotari lhotari reopened this Oct 4, 2022
@lhotari
lhotari merged commit 4742b6f into apache:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants