Skip to content

[improve][doc] add managedLedgerDataReadPriority configuration description - #18354

Closed
ethqunzhong wants to merge 2 commits into
apache:masterfrom
ethqunzhong:branch-add-managedLedgerDataReadPriority-doc
Closed

[improve][doc] add managedLedgerDataReadPriority configuration description#18354
ethqunzhong wants to merge 2 commits into
apache:masterfrom
ethqunzhong:branch-add-managedLedgerDataReadPriority-doc

Conversation

@ethqunzhong

@ethqunzhong ethqunzhong commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Motivation

doc for #17803

Documentation

Check the box below or label this PR directly.
Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)
  • doc-not-needed
    (Please explain why)
  • doc
    (Your PR contains doc changes)
  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository:
ethqunzhong#4

@github-actions github-actions Bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 6, 2022
@Anonymitaet
Anonymitaet requested a review from hangc0276 November 7, 2022 01:11
@Anonymitaet

Copy link
Copy Markdown
Member

@ethqunzhong from now on, the configuration docs are available at Pulsar Reference and generated automatically from code.

image

For how to update configuration docs, see https://pulsar.apache.org/contribute/documentation/contribution#update-pulsar-configuration-docs

@Anonymitaet

Copy link
Copy Markdown
Member

cc @DaveDuggins @momo-jun

@Anonymitaet

Copy link
Copy Markdown
Member

@hangc0276 could you please review this PR from a technical perspective? Thank you!

@ethqunzhong

Copy link
Copy Markdown
Contributor Author

@ethqunzhong from now on, the configuration docs are available at Pulsar Reference and generated automatically from code.

image

For how to update configuration docs, see https://pulsar.apache.org/contribute/documentation/contribution#update-pulsar-configuration-docs

thx for your advice. This is an efficient way to update pulsar configuration.

@github-actions

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions Bot added the Stale label Dec 10, 2022
Comment thread site2/website/versioned_docs/version-2.10.x/reference-configuration.md Outdated
@ethqunzhong
ethqunzhong requested review from momo-jun and removed request for hangc0276 December 12, 2022 07:31

@momo-jun momo-jun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@momo-jun momo-jun added this to the 2.11.0 milestone Dec 12, 2022
@momo-jun
momo-jun requested review from hangc0276 and zymap December 13, 2022 05:43
@RobertIndie RobertIndie modified the milestones: 2.11.0, 3.1.0 Apr 11, 2023
@tisonkun

Copy link
Copy Markdown
Member

Closing..

The source of docs are moved to https://github.com/apache/pulsar-site. Please open a PR there if you want to proceed this patch. And feel free to ping me for reviewing.

@tisonkun tisonkun closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants