[feat][broker] Expose pulsar out bytes and message metrics per topic - #18440
Open
pgier wants to merge 1 commit into
Open
[feat][broker] Expose pulsar out bytes and message metrics per topic#18440pgier wants to merge 1 commit into
pgier wants to merge 1 commit into
Conversation
Add prometheus metrics which expose the per topic messages out and bytes out total on a per topic basis. Currently, only the subscription level stats are enabled. Signed-off-by: Paul Gier <paul.gier@datastax.com>
pgier
changed the title
RobertIndie
approved these changes
Nov 18, 2022
liangyepianzhou
approved these changes
Nov 24, 2022
Technoboy-
changed the title
Technoboy-
approved these changes
Nov 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #18440 +/- ##
============================================
- Coverage 45.67% 44.03% -1.64%
- Complexity 10075 18476 +8401
============================================
Files 693 1791 +1098
Lines 67940 155298 +87358
Branches 7273 19054 +11781
============================================
+ Hits 31030 68392 +37362
- Misses 33333 79241 +45908
- Partials 3577 7665 +4088
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The pr had no activity for 30 days, mark with Stale label. |
dao-jun
approved these changes
Mar 1, 2023
Member
|
/pulsarbot run-failure-checks |
Contributor
|
@pgier there's a test failure: https://github.com/apache/pulsar/actions/runs/4664751844/jobs/8257572250?pr=18440#step:11:1521 |
|
The pr had no activity for 30 days, mark with Stale label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prometheus metrics which expose the per topic messages out and bytes out total on a per topic basis. Currently, only the subscription level stats are enabled.
Motivation
There are currently two metrics
pulsar_out_bytes_totalandpulsar_out_messages_total. The metrics represent the pulsar stats on a per subscription basis. It would be convenient to be able to see the summary of these values per topic similar to the stats exposed by pulsar-admin.Modifications
Added the two metrics and updated the test to verify that the output is correct.
Verifying this change
This change is already covered by existing tests, such as (please describe tests). I made an enhancement to the existing Promtheus metrics test.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: pgier#1