Skip to content

[feat][broker] Expose pulsar out bytes and message metrics per topic #18440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pgier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[feat][broker] Expose pulsar out bytes and message metrics per topic #18440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TopicStats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,10 @@ public static void printTopicStats(PrometheusMetricStreams stream, TopicStats st
splitTopicAndPartitionIndexLabel);
writeMetric(stream, "pulsar_in_messages_total", stats.msgInCounter, cluster, namespace, topic,
splitTopicAndPartitionIndexLabel);
writeMetric(stream, "pulsar_out_bytes_total", stats.bytesOutCounter, cluster, namespace, topic,
splitTopicAndPartitionIndexLabel);
writeMetric(stream, "pulsar_out_messages_total", stats.msgOutCounter, cluster, namespace, topic,
splitTopicAndPartitionIndexLabel);

// Compaction
boolean hasCompaction = compactorMXBean.flatMap(mxBean -> mxBean.getCompactionRecordForTopic(topic))
Expand Down
51 changes: 38 additions & 13 deletions pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,12 +268,17 @@ public void testPerTopicStats() throws Exception {
.subscriptionName("test")
.subscribe();

Consumer<byte[]> c2 = pulsarClient.newConsumer()
Consumer<byte[]> c2a = pulsarClient.newConsumer()
.topic("persistent://my-property/use/my-ns/my-topic2")
.subscriptionName("test")
.subscriptionName("test2a")
.subscribe();

final int messages = 10;
Consumer<byte[]> c2b = pulsarClient.newConsumer()
.topic("persistent://my-property/use/my-ns/my-topic2")
.subscriptionName("test2b")
.subscribe();

final int messages = 5;

for (int i = 0; i < messages; i++) {
String message = "my-message-" + i;
Expand All @@ -283,7 +288,8 @@ public void testPerTopicStats() throws Exception {

for (int i = 0; i < messages; i++) {
c1.acknowledge(c1.receive());
c2.acknowledge(c2.receive());
c2a.acknowledge(c2a.receive());
c2b.acknowledge(c2b.receive());
}

ByteArrayOutputStream statsOut = new ByteArrayOutputStream();
Expand Down Expand Up @@ -329,27 +335,46 @@ public void testPerTopicStats() throws Exception {
assertEquals(cm.get(1).tags.get("namespace"), "my-property/use/my-ns");

cm = (List<Metric>) metrics.get("pulsar_out_bytes_total");
assertEquals(cm.size(), 2);
assertEquals(cm.size(), 5);
assertEquals(cm.get(0).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic2");
assertEquals(cm.get(0).tags.get("namespace"), "my-property/use/my-ns");
assertEquals(cm.get(0).tags.get("subscription"), "test");
assertEquals(cm.get(1).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic1");
assertEquals(cm.get(0).tags.get("subscription"), "test2b");
assertEquals(cm.get(1).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic2");
assertEquals(cm.get(1).tags.get("namespace"), "my-property/use/my-ns");
assertEquals(cm.get(1).tags.get("subscription"), "test");
assertEquals(cm.get(1).tags.get("subscription"), "test2a");
assertEquals(cm.get(2).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic2");
assertEquals(cm.get(2).tags.get("namespace"), "my-property/use/my-ns");
assertNull(cm.get(2).tags.get("subscription"));
assertEquals(cm.get(3).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic1");
assertEquals(cm.get(3).tags.get("namespace"), "my-property/use/my-ns");
assertEquals(cm.get(3).tags.get("subscription"), "test");
assertEquals(cm.get(4).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic1");
assertEquals(cm.get(4).tags.get("namespace"), "my-property/use/my-ns");

cm = (List<Metric>) metrics.get("pulsar_out_messages_total");
assertEquals(cm.size(), 2);
assertEquals(cm.size(), 5);
assertEquals(cm.get(0).value, 5);
assertEquals(cm.get(0).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic2");
assertEquals(cm.get(0).tags.get("namespace"), "my-property/use/my-ns");
assertEquals(cm.get(0).tags.get("subscription"), "test");
assertEquals(cm.get(1).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic1");
assertEquals(cm.get(0).tags.get("subscription"), "test2b");
assertEquals(cm.get(1).value, 5);
assertEquals(cm.get(1).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic2");
assertEquals(cm.get(1).tags.get("namespace"), "my-property/use/my-ns");
assertEquals(cm.get(1).tags.get("subscription"), "test");
assertEquals(cm.get(1).tags.get("subscription"), "test2a");
assertEquals(cm.get(2).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic2");
assertEquals(cm.get(2).tags.get("namespace"), "my-property/use/my-ns");
assertNull(cm.get(2).tags.get("subscription"));
assertEquals(cm.get(3).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic1");
assertEquals(cm.get(3).tags.get("namespace"), "my-property/use/my-ns");
assertEquals(cm.get(3).tags.get("subscription"), "test");
assertEquals(cm.get(4).tags.get("topic"), "persistent://my-property/use/my-ns/my-topic1");
assertEquals(cm.get(4).tags.get("namespace"), "my-property/use/my-ns");

p1.close();
p2.close();
c1.close();
c2.close();
c2a.close();
c2b.close();
}

@Test
Expand Down
Loading