[fix] [txn] Revert: Make txn metrics name conforms to the rule (#17905) - #18524
Closed
pgier wants to merge 2 commits into
Closed
[fix] [txn] Revert: Make txn metrics name conforms to the rule (#17905)#18524pgier wants to merge 2 commits into
pgier wants to merge 2 commits into
Conversation
pgier
changed the title
pgier
force-pushed
the
revert-make-txn-metrics-name-conforms-to-rule
branch
from
November 17, 2022 16:31
d050b03 to
a422f30
Compare
12 tasks
The broker PromtheusMetrics should be reliable enough to run in the main broker test group. Signed-off-by: Paul Gier <paul.gier@datastax.com>
pgier
force-pushed
the
revert-make-txn-metrics-name-conforms-to-rule
branch
from
November 17, 2022 19:40
e7e5b48 to
cd258d0
Compare
Member
Contributor
Author
|
Closing this because it's resolved by #18539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3715934. This change broke several unit tests around metrics. It should be reverted until the associated tests are fixed.
Signed-off-by: Paul Gier paul.gier@datastax.com
Motivation
Prometheus metrics unit tests are currently broken due to #17905. This temporarily reverts those changes
until the tests are fixed.
Modifications
git revert 3715934
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: pgier#3