[fix][test] Fix PrometheusMetricsTest.testBrokerConnection - #18539
Merged
Conversation
nicoloboschi
approved these changes
Nov 18, 2022
12 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18539 +/- ##
=============================================
+ Coverage 31.39% 47.05% +15.66%
- Complexity 6651 10422 +3771
=============================================
Files 697 697
Lines 68015 68023 +8
Branches 7285 7284 -1
=============================================
+ Hits 21353 32010 +10657
+ Misses 43667 32447 -11220
- Partials 2995 3566 +571
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
RobertIndie
approved these changes
Nov 18, 2022
Member
Author
|
/pulsarbot run-failure-checks |
14 tasks
Technoboy-
approved these changes
Nov 19, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18535
Motivation
in #17905, we enable transaction coordinator in the broker, this will lead to opening a connection in broker, so connection_count should recalculate.
Modifications
Enable transaction coordinator in broker only in
testDuplicateMetricTypeDefinitions.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: coderzc#33