[fix][cli] pulsar-perf fails on jdk17 - #18806
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18806 +/- ##
============================================
- Coverage 50.05% 47.42% -2.63%
+ Complexity 11024 10622 -402
============================================
Files 703 703
Lines 68814 68814
Branches 7378 7378
============================================
- Hits 34446 32638 -1808
- Misses 30621 32546 +1925
+ Partials 3747 3630 -117
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mattisonchao
approved these changes
Dec 8, 2022
hezhangjian
approved these changes
Dec 8, 2022
nodece
approved these changes
Dec 8, 2022
Jason918
approved these changes
Dec 8, 2022
13 tasks
Technoboy-
approved these changes
Dec 8, 2022
congbobo184
approved these changes
Dec 8, 2022
Technoboy-
pushed a commit
that referenced
this pull request
Dec 8, 2022
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 26, 2022
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 29, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
|
Hi, I also get this error from pulsar java client api using Java 17. When I add pulsar to my application should I also use the JVM option mentioned above? Or there will be a fix for this? Running previous versions of pulsar client with Java 17 were not giving this error... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-perffails with jdk17.Modifications
Add
--add-openslike in the other cli tools.Documentation
docdoc-requireddoc-not-neededdoc-complete