Skip to content

[fix][cli] pulsar-perf fails on jdk17 - #18806

Merged
Technoboy- merged 1 commit into
apache:masterfrom
nicoloboschi:perf-jdk17
Dec 8, 2022
Merged

[fix][cli] pulsar-perf fails on jdk17#18806
Technoboy- merged 1 commit into
apache:masterfrom
nicoloboschi:perf-jdk17

Conversation

@nicoloboschi

Copy link
Copy Markdown
Contributor

Motivation

pulsar-perf fails with jdk17.

2022-12-06T09:43:53,357-0600 [pulsar-perf-producer-exec-1-1] WARN  io.netty.resolver.dns.DnsServerAddressStreamProviders - Can not find io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider in the classpath, fallback to system defaults. This may result in incorrect DNS resolutions on MacOS.
2022-12-06T09:43:53,369-0600 [pulsar-perf-producer-exec-1-1] WARN  org.apache.pulsar.common.util.netty.DnsResolverUtil - Cannot get DNS TTL settings from sun.net.InetAddressCachePolicy class
java.lang.IllegalAccessException: class org.apache.pulsar.common.util.netty.DnsResolverUtil cannot access class sun.net.InetAddressCachePolicy (in module java.base) because module java.base does not export sun.net to unnamed module @6456fb59
    at jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392) ~[?:?]
    at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674) ~[?:?]

Modifications

Add --add-opens like in the other cli tools.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codecov-commenter

codecov-commenter commented Dec 8, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.42%. Comparing base (68ca60c) to head (78b6a93).
⚠️ Report is 3183 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18806      +/-   ##
============================================
- Coverage     50.05%   47.42%   -2.63%     
+ Complexity    11024    10622     -402     
============================================
  Files           703      703              
  Lines         68814    68814              
  Branches       7378     7378              
============================================
- Hits          34446    32638    -1808     
- Misses        30621    32546    +1925     
+ Partials       3747     3630     -117     
Flag Coverage Δ
unittests 47.42% <ø> (-2.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 115 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Technoboy-
Technoboy- merged commit e0bdfbc into apache:master Dec 8, 2022
Demogorgon314 pushed a commit to Demogorgon314/pulsar that referenced this pull request Dec 26, 2022
Demogorgon314 pushed a commit to Demogorgon314/pulsar that referenced this pull request Dec 29, 2022
lifepuzzlefun pushed a commit to lifepuzzlefun/pulsar that referenced this pull request Jan 10, 2023
@oguzhantortop

Copy link
Copy Markdown

Hi, I also get this error from pulsar java client api using Java 17. When I add pulsar to my application should I also use the JVM option mentioned above? Or there will be a fix for this? Running previous versions of pulsar client with Java 17 were not giving this error...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants