Skip to content

[improve][ci] Gradle Enterprise Configuration Tweaks - #19194

Merged
lhotari merged 4 commits into
apache:masterfrom
clayburn:gradle-enterprise-tweaks
Jan 12, 2023
Merged

[improve][ci] Gradle Enterprise Configuration Tweaks#19194
lhotari merged 4 commits into
apache:masterfrom
clayburn:gradle-enterprise-tweaks

Conversation

@clayburn

@clayburn clayburn commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Motivation

This change updates the Gradle Enterprise configuration in a few small ways to keep the configuration up to date with best practices.

Modifications

  • Update to version 1.16.2 of the Gradle Enterprise Maven Extension
  • Use newer syntax for Gradle Enterprise goal input capture
  • Only enable the Gradle Enterprise local build cache for non-CI builds
  • Disable the Gradle Enterprise remote cache for all builds

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 11, 2023
@tisonkun
tisonkun requested a review from lhotari January 12, 2023 04:21

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution!

@lhotari

lhotari commented Jan 12, 2023

Copy link
Copy Markdown
Member

/pulsarbot rerun-failure-checks

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #19194 (07e23e5) into master (4b0dc9a) will decrease coverage by 11.63%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19194       +/-   ##
=============================================
- Coverage     48.96%   37.33%   -11.64%     
+ Complexity     7300     1994     -5306     
=============================================
  Files           424      209      -215     
  Lines         45473    14450    -31023     
  Branches       4672     1577     -3095     
=============================================
- Hits          22268     5395    -16873     
+ Misses        20698     8475    -12223     
+ Partials       2507      580     -1927     
Flag Coverage Δ
unittests 37.33% <ø> (-11.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/service/persistent/GeoPersistentReplicator.java
.../pulsar/broker/admin/impl/SchemasResourceBase.java
...saction/timeout/TransactionTimeoutTrackerImpl.java
...ulsar/broker/intercept/BrokerInterceptorUtils.java
...broker/delayed/InMemoryDelayedDeliveryTracker.java
...a/org/apache/pulsar/broker/admin/v3/Functions.java
...ker/loadbalance/impl/SimpleLoadCalculatorImpl.java
...org/apache/pulsar/broker/admin/v1/BrokerStats.java
.../apache/pulsar/proxy/server/AdminProxyHandler.java
...ker/loadbalance/impl/LeastLongTermMessageRate.java
... and 623 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants