CURATOR-669. Integrate with ge.apache.org Gradle Enterprise server - #459
Conversation
Signed-off-by: tison <wander4096@gmail.com>
|
We can review the flaky tests and test time cost for further improving. |
clayburn
left a comment
clayburn
left a comment
There was a problem hiding this comment.
Hi, I am a Solutions engineer with Gradle assisting with the Gradle Enterprise rollout. It is exciting to see your interest in sending build scans for the Curator build to https://ge.apache.org! I've added some best practice recommendations to the pull request.
If you have any questions regarding Gradle Enterprise, please feel free to reach out and we would be happy to help you. I see your primary use case is the Test analytics, but after this project is connected, we will run some experiment builds to check how well your build utilizes the build cache and submit back any fixes we discover.
|
|
||
| if (System.env.MAVEN_CMD_LINE_ARGS) { | ||
| mavenCommand = "mvn ${System.env.MAVEN_CMD_LINE_ARGS}".toString() | ||
| buildScan.value('Maven command line', mavenCommand) |
There was a problem hiding this comment.
I would be very careful capturing the entire Maven command line. You could imagine scenarios where a user passes in a secret as a system property, or possibly even typos that include secrets. Gradle Enterprise doesn't capture certain environment details for this reason.
Perhaps it would make more sense to capture specific details you may be interested in? For example, we already add a custom value for the skipTests setting. We also have samples to capture profiles as tags. This may actually make it easier to queries that combine the different values, rather than trying to construct queries that are considering the command line as a whole. It may also be more accurate, as capturing the value of configured properties would not only capture values passed in at the command line.
There was a problem hiding this comment.
I'll leave it as is for now. If you have better config suggestions, feel free to patch the script based on this branch or after this patch gets merged.
There was a problem hiding this comment.
OK. I'm trying to redact mvn command.
@tisonkun - should just be a matter of removing this if (System.env.MAVEN_CMD_LINE_ARGS) { ... } block
|
Just wanted to follow up on this. I know you originally looked at the Gradle Enterprise configuration in the Pulsar project. We've filed a PR there with a couple of changes over there to follow some new recommendations that come with Gradle Enterprise Maven Extension 1.17. |
|
@clayburn Thanks for your updates. I'll catch up changes in weeks :) |
Signed-off-by: tison <wander4096@gmail.com>
|
OK. I'm trying to redact mvn command. |
|
After a closer look, I'm going to remove the if block for now. |
Signed-off-by: tison <wander4096@gmail.com>
|
This test is failing on the Java 8 test build: https://ge.apache.org/s/ovviiad2aixry/tests/overview?outcome=failed I don't know much about your test suite, but I would assume this one is not related to the changes in this PR? |
|
@clayburn Yep. I have rerun the tests and such flaky tests are part of issue we want to located and resolve with the help of Gradle Enterprise integration. |
|
Reported to https://issues.apache.org/jira/browse/CURATOR-671. I saw this also in #460(parallel with this pr). cc @clayburn @tisonkun |
|
Pending to merge... |
3 participants
https://issues.apache.org/jira/browse/CURATOR-669
See -
I'd prefer to use this method for analyzing our flaky tests and time-consuming tests for further improving.