[improve][ci] Improve code coverage reporting - #19296
Merged
lhotari merged 8 commits intoJan 20, 2023
Merged
Conversation
- use test scope classpath to collect correct dependencies - exclude test projects so that coverage doesn't get reported for them
lhotari
force-pushed
the
lh-improve-code-coverage-collecting
branch
from
January 20, 2023 09:14
70483b3 to
72a5f03
Compare
nicoloboschi
approved these changes
Jan 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #19296 +/- ##
=============================================
+ Coverage 52.84% 62.89% +10.04%
- Complexity 22367 26118 +3751
=============================================
Files 1824 1895 +71
Lines 136749 137475 +726
Branches 15047 15091 +44
=============================================
+ Hits 72264 86460 +14196
+ Misses 56968 43085 -13883
- Partials 7517 7930 +413
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After reviewing the latest changes made in #19264 for collecting code coverage in a new way, there are a few details that need to be adjusted.
The Codecov results can be seen for the PR commit at
https://app.codecov.io/github/apache/pulsar/commit/62060c814bf90de9b8f7cd520e2dc5459b394cbe/tree
The build workflow run contained Jacoco html reports at https://github.com/apache/pulsar/actions/runs/3961486478 .
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete