Skip to content

[improve][ci] CI code coverage collecting improvements - #19303

Merged
lhotari merged 8 commits into
apache:masterfrom
lhotari:lh-codecov-improvements
Jan 23, 2023
Merged

[improve][ci] CI code coverage collecting improvements #19303
lhotari merged 8 commits into
apache:masterfrom
lhotari:lh-codecov-improvements

Conversation

@lhotari

@lhotari lhotari commented Jan 22, 2023

Copy link
Copy Markdown
Member

Motivation

Code coverage for master branch need pulsar-ci-flaky to run with a scheduled job since flaky tests are also part of
the coverage.
This PR contains some improvements and follow up on #19264 and #19296 changes.

Modifications

  • add scheduling to pulsar-ci-flaky
  • make Jacoco agent use unique files for forked test processes to reduce chances of file corruption and contention
  • don't use failfast mode for flaky tests and quarantined tests since it impacts coverage results
  • suppress excessive logging when zipping jacoco html reports
  • filter out empty .exec files
  • skip uploading pulsar-io META-INF/bundled-dependencies files which take up over 900MB

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 2.12.0 milestone Jan 22, 2023
@lhotari
lhotari requested a review from nicoloboschi January 22, 2023 17:05
@lhotari lhotari self-assigned this Jan 22, 2023
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 22, 2023
@lhotari

lhotari commented Jan 22, 2023

Copy link
Copy Markdown
Member Author

/pulsarbot rerun-failure-checks

@lhotari
lhotari force-pushed the lh-codecov-improvements branch from ea2afa3 to 414dfeb Compare January 22, 2023 19:27
@lhotari
lhotari requested review from Jason918 and tisonkun January 22, 2023 19:28

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #19303 (414dfeb) into master (457a0d5) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19303      +/-   ##
============================================
+ Coverage     63.54%   63.83%   +0.29%     
- Complexity     3615    26040   +22425     
============================================
  Files          1895     1818      -77     
  Lines        137475   133058    -4417     
  Branches      15091    14637     -454     
============================================
- Hits          87355    84940    -2415     
+ Misses        42240    40369    -1871     
+ Partials       7880     7749     -131     
Flag Coverage Δ
inttests 24.93% <ø> (+0.75%) ⬆️
systests 25.67% <ø> (-0.18%) ⬇️
unittests 61.18% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ulsar/broker/delayed/bucket/DelayedIndexQueue.java 0.00% <0.00%> (-100.00%) ⬇️
...lsar/websocket/admin/v1/WebSocketProxyStatsV1.java 0.00% <0.00%> (-100.00%) ⬇️
...aming/FlowOrQpsEquallyDivideBundleSplitOption.java 0.00% <0.00%> (-100.00%) ⬇️
...ed/bucket/TripleLongPriorityDelayedIndexQueue.java 0.00% <0.00%> (-100.00%) ⬇️
...ng/FlowOrQpsEquallyDivideBundleSplitAlgorithm.java 1.66% <0.00%> (-83.34%) ⬇️
...elayed/bucket/BookkeeperBucketSnapshotStorage.java 0.00% <0.00%> (-82.53%) ⬇️
...layed/bucket/CombinedSegmentDelayedIndexQueue.java 0.00% <0.00%> (-82.50%) ⬇️
.../apache/pulsar/utils/CmdGenerateDocumentation.java 0.00% <0.00%> (-76.93%) ⬇️
...he/pulsar/broker/service/PrecisPublishLimiter.java 0.00% <0.00%> (-73.98%) ⬇️
.../apache/pulsar/websocket/stats/ProxyTopicStat.java 0.00% <0.00%> (-60.00%) ⬇️
... and 233 more

@lhotari
lhotari merged commit e0f79bf into apache:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants