[improve][broker] Add test to verify authRole cannot change - #19430
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19430 +/- ##
============================================
+ Coverage 62.63% 62.66% +0.02%
- Complexity 25752 25768 +16
============================================
Files 1832 1832
Lines 134053 134067 +14
Branches 14752 14753 +1
============================================
+ Hits 83967 84014 +47
+ Misses 42346 42340 -6
+ Partials 7740 7713 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 15, 2023
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 15, 2023
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 16, 2023
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 17, 2023
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
Feb 17, 2023
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 17, 2023
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 17, 2023
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 22, 2023
michaeljmarshall
added a commit
to michaeljmarshall/pulsar
that referenced
this pull request
Feb 23, 2023
Member
Author
|
I cherry picked this test because it is valid for all release branches and it ensured correctness for some of my cherry picked changes, which is very valuable. |
hangc0276
added a commit
to hangc0276/pulsar
that referenced
this pull request
Mar 15, 2023
…pache#19430)" This reverts commit 0231ad3.
15 tasks
hangc0276
added a commit
to hangc0276/pulsar
that referenced
this pull request
Mar 15, 2023
…pache#19430)" This reverts commit 3e90bc2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While working on #19409, I noticed we do not have any tests in the
ServerCnxTestsclass verifying theauthRolecannot change. This seems like an oversight, and this PR adds tests to assert the existing behavior works as intended.Modifications
AuthenticationProviderandAuthenticationStateimplementations to simplify testingauthRolechanges.Verifying this change
This change is to add tests.
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: Skipping testing in my fork since these are new tests and I got them to pass locally.