Skip to content

[Branch-2.10] Revert [improve][broker] Require authRole is proxyRole to set originalPrincipal(#19455) - #19824

Closed
hangc0276 wants to merge 9 commits into
apache:branch-2.10from
hangc0276:chenhang/branch-2.10-revert-6a599af
Closed

[Branch-2.10] Revert [improve][broker] Require authRole is proxyRole to set originalPrincipal(#19455)#19824
hangc0276 wants to merge 9 commits into
apache:branch-2.10from
hangc0276:chenhang/branch-2.10-revert-6a599af

Conversation

@hangc0276

Copy link
Copy Markdown
Contributor

Motivation

PR #19455 introduced break change and has been cherry-picked to release branch-2.10. It will lead to users upgrading to the new release version authenticate failed. We need to revert all the related PRs.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Mar 15, 2023

@michaeljmarshall michaeljmarshall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, this is the wrong thing to change and should not all be reverted regardless of the PMC's decision.

Second, we need consensus on the private mailing list before we merge this.

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @michaeljmarshall

@codelipenghui

Copy link
Copy Markdown
Contributor

We have an acceptable solution for now. So that we don't need to revert this change, just push a fix to the release branches.
https://lists.apache.org/thread/q1k1krfjr8njdf8t3sy1ht4vg67s4x71 the discussion thread.

And @michaeljmarshall message me in Slack, he will open PR to fix it.

Thanks @hangc0276 and @michaeljmarshall

@michaeljmarshall

Copy link
Copy Markdown
Member

@hangc0276, in my view, #19830 should supersede this PR once it is merged and cherry picked to 2.10. Is there a reason you proposed reverting so many other changes? Thanks.

@michaeljmarshall

Copy link
Copy Markdown
Member

I don't think we should revert any of the other commits--I intentionally cherry picked each for a reason. With #19830 merged and cherry picked, the original intention of this PR is fulfilled. Please reopen if I missed something @hangc0276.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants