[improve][build] Capture local build scans on ge.apache.org to benefit from deep build insights - #20187
Merged
tisonkun merged 2 commits intoApr 30, 2023
Conversation
With updates in Gradle Enterprise Maven Extension 1.17, the `publishIfAuthenticated` configuration will silently not publish a build scan if the user is not authenticated to https://ge.apache.org.
Member
|
/pulsarbot rerun-failure-checks |
tisonkun
approved these changes
Apr 29, 2023
tisonkun
left a comment
Member
There was a problem hiding this comment.
Although I'm thinking of further cleanup for setting:
env:
GRADLE_ENTERPRISE_ACCESS_KEY: ...and drop the handmade action, it should not be a blocker to us for merging this patch.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20187 +/- ##
============================================
+ Coverage 72.25% 72.92% +0.66%
+ Complexity 31952 31858 -94
============================================
Files 1855 1868 +13
Lines 138267 138468 +201
Branches 15222 15236 +14
============================================
+ Hits 99901 100973 +1072
+ Misses 30386 29460 -926
- Partials 7980 8035 +55
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR publishes a build scan for every CI build on GitHub Actions and for every local build from an authenticated Apache committer. The build will not fail if publishing fails.
The build scans of the Apache Pulsar project are published to the Gradle Enterprise instance at ge.apache.org, hosted by the Apache Software Foundation and run in partnership between the ASF and Gradle. This Gradle Enterprise instance has all features and extensions enabled and is freely available for use by the Apache Pulsar project and all other Apache projects.
Currently, the Apache Pulsar build is configured to publish build scans to ge.apache.org for CI only. This pull request enhances that functionality by also publishing build scans to ge.apache.org for authenticated Apache committers. On this Gradle Enterprise instance, Apache Pulsar will have access not only to all of the published build scans but other aggregate data features such as:
Modifications
ge-extensions.xmlin favor of the more conventionalextensions.xmlfile. Updates to thepublishIfAuthenticatedproperty in Gradle Enterprise Maven Extension 1.17 will cause the build to print no output if the user is not authenticated to ge.apache.org.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: