[draft][fix][build] More Heap for Maven Surefire Tests - #20774
Conversation
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Do we have some profile to improve the tests in the other side? The total CI resources are limited IIRC.
|
/pulsarbot run-failure-checks |
|
Tests running into OOM is a sign of a resource leak. When the heap is increased, the possible resource leak would be tolerated, but the problem would remain. |
If it's okay, can we have reference(link to) the feature that is being refered to? @lhotari |
|
This issue might bring us back to thread of @dave2wave in the mailing list |
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <argLine>${testJacocoAgentArgument} -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=${testHeapDumpPath} -XX:+ExitOnOutOfMemoryError -Xmx1G -XX:+UseZGC | ||
| <argLine>${testJacocoAgentArgument} -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=${testHeapDumpPath} -XX:+ExitOnOutOfMemoryError -Xmx1532M -XX:+UseZGC |
There was a problem hiding this comment.
Instead of changing this, make the parameter configurable so that this can be increased if someone is running all tests together. For Pulsar CI, it's better to keep this value at 1G.
So what you could do is adding a separate maven property "testMaxHeapSize" so that it can be passed from the command line with -DtestMaxHeapSize=1532M. Makes sense?
|
btw. One of the recently fixed resource leaks in tests is #20778 by @Technoboy- |
|
#20799 fixes a major resource leak in tests. |
|
The two fixes are definite improvements. There are still a few issues to look into. |
dave2wave
changed the title
|
The pr had no activity for 30 days, mark with Stale label. |
6 participants
Motivation
Builds on 3.0 and Master branches are failing during tests. SOme of the tests use up the heap and OOM.
Modifications
Changes surefire to
-Xms1532MVerifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete