[fix][test] Fix resource leak in PulsarTestContext - #20799
Merged
lhotari merged 4 commits intoJul 13, 2023
Conversation
- use fields in super class to hold resources instead of having duplicates - all fields in PulsarService have protected setters due to `@Setter(AccessLevel.PROTECTED)` - this fact was missed in the original implementation of PulsarTestContext
lhotari
added
type/bug
lhotari
requested review from
Technoboy-,
dave2wave,
eolivelli,
michaeljmarshall and
nicoloboschi
July 13, 2023 12:19
eolivelli
approved these changes
Jul 13, 2023
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
Great catch !
Thank you very much for fixing this long standing issue
BewareMyPower
approved these changes
Jul 13, 2023
5 tasks
lhotari
added a commit
that referenced
this pull request
Jul 13, 2023
(cherry picked from commit ae0fc5b)
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20797
Motivation
See #20797. There's a resource leak in PulsarTestContext which was introduced in #19337 and #19376.
PulsarTestContext was a solution that was made to reduce the usage of Mockito so that issues like #13620 could be fixed. Mockito is not thread safe and that is the reason why PulsarTestContext was needed.
Modifications
@Setter(AccessLevel.PROTECTED)Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lhotari#152