[fix][test] Fix flaky test testCloseTransactionBufferWhenTimeout and close producer/consumer - #20956
Merged
Merged
Conversation
tisonkun
approved these changes
Aug 11, 2023
tisonkun
left a comment
tisonkun
left a comment
Member
There was a problem hiding this comment.
All other PRs can be blocked by this flaky test. I'm looking into it now.
mattisonchao
approved these changes
Aug 11, 2023
lifepuzzlefun
approved these changes
Aug 11, 2023
Member
|
Merging... |
Member
|
Thank a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When fixing the flaky test
testCloseTransactionBufferWhenTimeout, I see many producers/consumers not closed after the test. Some related fixing #20799, #20778Fix
KeySharedSubscriptionTesthttps://github.com/apache/pulsar/actions/runs/5804173763/job/15735680439?pr=20952
https://github.com/apache/pulsar/actions/runs/5804311503/job/15733845297?pr=20963
https://github.com/apache/pulsar/actions/runs/5796922794/job/15735725061?pr=20943
Documentation
docdoc-requireddoc-not-neededdoc-complete