[fix][broker] Fix brokerId npe problem

[TakaHiR07]

Motivation

As shown in #22975.

Modifications

generate brokerId when construct PulsarService, instead of in PulsarService.start().

Verifying this change

• Make sure that the change passes the CI checks.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[lhotari]

I don't think that this works for the case when a dynamic port (0) is used on the broker. Dynamic ports are used for tests.

A proper solution would be to postpone any calls until the broker id is available.

[lhotari]

I'll propose another PR which also makes an improvement to ensure that the broker doesn't start serving requests before it has been fully started. That will also prevent other edge cases.

[lhotari]

@TakaHiR07 I have created #22977 which addresses the brokerId NPE problem.

[TakaHiR07]

I'll propose another PR which also makes an improvement to ensure that the broker doesn't start serving requests before it has been fully started. That will also prevent other edge cases.

Ok