Skip to content

[fix][broker] Fix brokerId npe problem #22976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TakaHiR07 wants to merge 1 commit into from
Closed

[fix][broker] Fix brokerId npe problem #22976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,12 @@ public PulsarService(ServiceConfiguration config,
// the advertised address is defined as the host component of the broker's canonical name.
this.advertisedAddress = ServiceConfigurationUtils.getDefaultOrConfiguredAddress(config.getAdvertisedAddress());

// the broker id is used in the load manager to identify the broker
// it should not be used for making connections to the broker
this.brokerId =
String.format("%s:%s", advertisedAddress, config.getWebServicePort()
.or(config::getWebServicePortTls).orElseThrow());

// use `internalListenerName` listener as `advertisedAddress`
this.bindAddress = ServiceConfigurationUtils.getDefaultOrConfiguredAddress(config.getBindAddress());
this.brokerVersion = PulsarVersion.getVersion();
Expand Down Expand Up @@ -918,12 +924,6 @@ public void start() throws PulsarServerException {
this.brokerServiceUrl = brokerUrl(config);
this.brokerServiceUrlTls = brokerUrlTls(config);

// the broker id is used in the load manager to identify the broker
// it should not be used for making connections to the broker
this.brokerId =
String.format("%s:%s", advertisedAddress, config.getWebServicePort()
.or(config::getWebServicePortTls).orElseThrow());

if (this.compactionServiceFactory == null) {
this.compactionServiceFactory = loadCompactionServiceFactory();
}
Expand Down