[fix][broker] Fix compaction service log's wrong condition

[poorbarcode]

Motivation

background

• This change is a follow-up on [fix][broker] Consumer stuck when delete subscription __compaction failed #23980, which added the log.
• If CompactedTopicImpl.newCompactedLedger was called more than once with the same compactedLedgerId, it will trigger a ledger deletion, which causes a data loss event.

Issue

• The condition of the log should be previousLedger == @param-newLedger, but it is @param-newLedger == @param-newLedger
• The impact is that there would be invalid error logs for every compaction

Modifications

Fix the wrong condition of printing error log

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: x

[poorbarcode]

/pulsarbot rerun-failure-checks

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (bbc6224) to head (851d05b).
Report is 1038 commits behind head on master.

Files with missing lines	Patch %	Lines
...g/apache/pulsar/compaction/CompactedTopicImpl.java	50.00%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #24207      +/-   ##
============================================
+ Coverage     73.57%   74.25%   +0.67%     
+ Complexity    32624    32528      -96     
============================================
  Files          1877     1865      -12     
  Lines        139502   144659    +5157     
  Branches      15299    16523    +1224     
============================================
+ Hits         102638   107410    +4772     
+ Misses        28908    28757     -151     
- Partials       7956     8492     +536     

Flag	Coverage Δ
inttests	26.72% <50.00%> (+2.14%)	⬆️
systests	23.28% <50.00%> (-1.05%)	⬇️
unittests	73.74% <50.00%> (+0.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...g/apache/pulsar/compaction/CompactedTopicImpl.java	61.53% <50.00%> (-0.89%)	⬇️

... and 1074 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lhotari]

The change itself is ok, but the title and description of the PR are not describing the relevant context of the change:

• The impact isn't described at all. The impact seems to be that there would be invalid error logs for every compaction. Is that correct?
• This change is a follow up on #23980 changes that haven't been released yet. It would be useful to mention this in the description that this is a follow up on #23980 changes.

[poorbarcode]

@lhotari

The impact isn't described at all. The impact seems to be that there would be invalid error logs for every compaction. Is that correct?
This change is a follow up on #23980 changes that haven't been released yet. It would be useful to mention this in the description that this is a follow up on #23980 changes.

Correct, Updated in the Motivation

[lhotari]

LGTM