Skip to content

[fix][broker] Fix compaction service log's wrong condition #24207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhotari merged 1 commit into from
Apr 24, 2025
Merged

[fix][broker] Fix compaction service log's wrong condition #24207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,20 @@ public CompletableFuture<CompactedTopicContext> newCompactedLedger(Position p, l

// delete the ledger from the old context once the new one is open
return compactedTopicContext.thenCompose(ctx -> {
if (ctx != null && ctx.getLedger() != null && ctx.getLedger().getId() == compactedLedgerId) {
// Print an error log here, which is not expected.
log.error("[__compaction] Using the same compacted ledger to override the old one, which is not"
+ " expected and it may cause a ledger lost error. {} -> {}", compactedLedgerId,
ctx.getLedger().getId());
if (previousContext != null) {
previousContext.thenAccept(previousCtx -> {
// Print an error log here, which is not expected.
if (previousCtx != null && previousCtx.getLedger() != null
&& previousCtx.getLedger().getId() == compactedLedgerId) {
log.error("[__compaction] Using the same compacted ledger to override the old one, which is"
+ " not expected and it may cause a ledger lost error. {} -> {}", compactedLedgerId,
ctx.getLedger().getId());
}
});
return previousContext;
} else {
return CompletableFuture.completedFuture(null);
}
return previousContext != null ? previousContext : CompletableFuture.completedFuture(null);
});
}
}
Expand Down