[fix][test] Fix flaky ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer - #25596
Merged
merlimat merged 1 commit intoApr 28, 2026
Conversation
…erviceUnitTableViewSyncer playLeader() and playFollower() run on a single-threaded loadManagerExecutor, so playLeader() on the new leader can be queued behind a still-running playFollower() from the prior demotion. The syncer.start() work itself opens both table views and runs syncExistingItems/syncTailItems. Under CI load this serial chain can exceed the previous 30s timeout. Increase the timeout to 60s for both syncer-state checks (active on new leader, inactive on demoted follower) and the symmetric pair in the cleanup section after the dynamic config is removed.
merlimat
deleted the
fix/flaky-testLoadBalancerServiceUnitTableViewSyncer
branch
April 28, 2026 17:52
2 tasks
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
May 6, 2026
…erviceUnitTableViewSyncer (apache#25596)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
…erviceUnitTableViewSyncer (apache#25596) (cherry picked from commit d69c787)
priyanshu-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 9, 2026
…erviceUnitTableViewSyncer (apache#25596) (cherry picked from commit d69c787) (cherry picked from commit b72fe75)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
testLoadBalancerServiceUnitTableViewSynceris flaky withexpected [true] but found [false]after the 30s wait forprimaryLoadManager.getServiceUnitStateTableViewSyncer().isActive().The
loadManagerExecutoris a single-threaded scheduled executor. AftermakeSecondaryAsLeader()followed immediately bymakePrimaryAsLeader(), the new leader'splayLeader()is queued behind any still-runningplayFollower()from the prior demotion.syncer.start()itself opens both table views and runssyncExistingItems+syncTailItems. Under CI load this serial chain can exceed 30s.Modifications
Increase the timeout from 30s to 60s for the syncer-state checks after both leader transitions, and apply the same to the symmetric pair in the cleanup section after the dynamic config is removed.
Verifying this change
Locally verified with 3 successful back-to-back runs of the test.